Disable Enzyme on Julia 1.12+ to fix CI test failures #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added global const ENZYME_ENABLED = VERSION < v"1.12" in one central location - Modified test/runtests.jl to conditionally install Enzyme based on ENZYME_ENABLED - Modified test/adjoint_tests.jl to conditionally run Enzyme tests - Easy to re-enable by changing the condition in the const definition - Resolves CI failures on Julia v1.12+ where Enzyme has compatibility issues 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Skip entire adjoint test on Julia 1.12+ since SciMLSensitivity/Mooncake aren't installed - Add Julia 1.11 to all CI workflows (top-level and all sublibs) - This ensures we test on both v1.11 (with Enzyme) and v1.12+ (without Enzyme) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Author
Additional fixesUpdated to skip the entire adjoint test on Julia 1.12+ rather than just conditionally importing Enzyme, since SciMLSensitivity and Mooncake also aren't installed on v1.12+. Also added Julia 1.11 to all CI workflows:
This ensures we test on both:
|
The previous approach using `return` didn't work because @testitem isn't a function scope. Using @static if prevents the package imports from being attempted at all on Julia 1.12+. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Author
Fixed: Use @static if instead of returnFixed the adjoint test to use Now the entire test body is conditionally compiled based on the Julia version, preventing the package imports from being attempted on Julia 1.12+. |
Added VERSION < v"1.12" check to all conditional Enzyme imports across all subpackage tests: - lib/NonlinearSolveBase/ext/NonlinearSolveBaseEnzymeExt.jl - lib/NonlinearSolveFirstOrder/test/rootfind_tests.jl - lib/NonlinearSolveHomotopyContinuation/test/allroots.jl - lib/NonlinearSolveHomotopyContinuation/test/single_root.jl - lib/NonlinearSolveQuasiNewton/test/core_tests.jl - lib/SciMLJacobianOperators/test/core_tests.jl - lib/SimpleNonlinearSolve/test/core/rootfind_tests.jl Changed from: if isempty(VERSION.prerelease) Changed to: if isempty(VERSION.prerelease) && VERSION < v"1.12" This ensures Enzyme is not loaded on Julia 1.12+ where it has compatibility issues. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Author
Updated all sublib Enzyme version checksExtended the Enzyme version check to all subpackage tests to prevent Enzyme from being loaded on Julia 1.12+. Files Updated:
Change:# Before
if isempty(VERSION.prerelease)
# After
if isempty(VERSION.prerelease) && VERSION < v"1.12"This ensures that all Enzyme imports and usage are properly skipped on Julia 1.12+ across the entire codebase, not just in the top-level tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI test failures on Julia v1 (1.12+) by conditionally disabling Enzyme, which currently has compatibility issues with Julia 1.12+.
Changes
ENZYME_ENABLED = VERSION < v"1.12"and updated package installation logicRe-enabling Enzyme
To re-enable Enzyme in the future (once compatibility is fixed), simply change the condition in both files:
This centralizes the Enzyme compatibility check in one easy-to-modify location.
Test plan
🤖 Generated with Claude Code